Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new URL to render a v2 xblock in an iframe [FC-0062] #35473

Merged
merged 4 commits into from
Sep 13, 2024
Merged

feat: new URL to render a v2 xblock in an iframe [FC-0062] #35473

merged 4 commits into from
Sep 13, 2024
+60 −3

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Sep 11, 2024 •
edited
Loading

Description

This PR adds an endpoint in the XBlock rest API to allow rendering it in the course authoring mfe

More information

Part of:

Testing Instructions

Check openedx/frontend-app-authoring#1242

Private ref: FAL-3801

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 11, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 11, 2024 •
edited
Loading

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@rpenido rpenido changed the title feat: new URL to render a v2 xblock in an iframe feat: new URL to render a v2 xblock in an iframe [FC-0062] Sep 11, 2024
@rpenido rpenido mentioned this pull request Sep 11, 2024
Merged
@rpenido rpenido marked this pull request as ready for review September 11, 2024 21:45
ChrisChV
ChrisChV approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good 👍

bradenmacdonald
bradenmacdonald requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! Can I just request one change? Could you please mark this new API endpoint as "Unstable - may change after Sumac" in both urls.py and views.py?

@rpenido
Copy link
Contributor Author

rpenido commented Sep 13, 2024 •
edited
Loading

Looks good to me too! Can I just request one change? Could you please mark this new API endpoint as "Unstable - may change after Sumac" in both urls.py and views.py?

Done: 8159ae6

Ops..
Amended here: eb1a0f3

@bradenmacdonald bradenmacdonald merged commit bb6ac5a into openedx:master Sep 13, 2024
49 checks passed
@bradenmacdonald bradenmacdonald deleted the xblock-v2-iframe branch September 13, 2024 18:45
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@ormsbee ormsbee mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisChV ChrisChV ChrisChV approved these changes

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rpenido @openedx-webhooks @edx-pipeline-bot @bradenmacdonald @ChrisChV